refactor(github-actions): Update issue labeler to apply milestones#3600
refactor(github-actions): Update issue labeler to apply milestones#3600josephperrott merged 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automatic milestone assignment to the issue labeling action. It updates the logic to handle both 'opened' and 'labeled' events, assigning the 'needsTriage' milestone for area labels and the 'Backlog' milestone for priority labels (P0-P5). A review comment points out an improvement opportunity regarding milestone persistence: the current implementation unconditionally overwrites existing milestones, which could accidentally remove manually assigned release milestones. It is suggested to only apply the milestone if the field is empty or if transitioning specifically from 'needsTriage' to 'Backlog'.
thePunderWoman
force-pushed
the
issue-milestone
branch
from
f453721 to
d2a39c0
Compare
thePunderWoman
force-pushed
the
issue-milestone
branch
from
d2a39c0 to
34355df
Compare
This updates the issue labeler to also run and apply the needsTriage and Backlog milestones when appropriate. This should eliminate the need for the ngbot entirely.
thePunderWoman
force-pushed
the
issue-milestone
branch
from
34355df to
8fb35c1
Compare
thePunderWoman
added
the
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
This updates the issue labeler to also run and apply the needsTriage and Backlog milestones when appropriate. This should eliminate the need for the ngbot entirely.